Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment position has to be relative to the diff #56

Closed
jfacorro opened this issue Jul 22, 2014 · 0 comments
Closed

Comment position has to be relative to the diff #56

jfacorro opened this issue Jul 22, 2014 · 0 comments

Comments

@jfacorro
Copy link
Contributor

The position argument provided when creating a PR review comment has to be relative to the file's diff and not to the file itself.
jfacorro added a commit that referenced this issue Jul 22, 2014
@jfacorro
[#56] Create comments with relative diff position.
fed5312
jfacorro added a commit that referenced this issue Jul 22, 2014
@jfacorro
[#56] Added test.
a9b26de
jfacorro added a commit that referenced this issue Jul 22, 2014
@jfacorro
[#56] Improved test. Fixed bug.
7ade715
elbrujohalcon added a commit that referenced this issue Jul 23, 2014
@elbrujohalcon
Merge pull request #57 from inaka/jfacorro.56.relative.comment.position
95d808a 
[#56] Relative position for PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfacorro