Fix line length for unicode files #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementaiton used byte_size for line length, however this gave false results for unicode files. In the end we are not interested in the number of bytes but the number of characters.
|
@Licenser would you mind adding/updating a test case for this? |
|
Done. Please note that the elvis test here fails because of the test file that includes a unicode line which trips the 80 character limit. With a fixed elvis this test is clean. |
elbrujohalcon
pushed a commit
that referenced
this pull request
Nov 17, 2015
Fix line length for unicode files
|
thank you very much, @Licenser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementaiton used byte_size for line length, however
this gave false results for unicode files. In the end we are not
interested in the number of bytes but the number of characters.