Fix bug where SSR is dispatched twice when errors exist #489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with the Inertia Blade directives that cause the SSR node server to be called twice in the event of a JavaScript related failure.
This happens because the
\Inertia\Ssr\Gateway
returns either an\Inertia\Ssr\Response
(on success), ornull
on failure (a JavaScript error), which is saved in the$__inertiaSsr
variable, and then we check to see if that variableisset
to prevent calling the SSR server twice. Problem is, in PHP callingisset()
on a variable that'snull
returnsfalse
, even if that variable has been set.This PR fixes this by introducing a new
$__inertiaSsrDispatched
variable to keep track of whether the SSR server has been dispatched, regardless of the response.