Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use New JuMP Macro API #334

Merged
merged 10 commits into from
Feb 1, 2024
Merged

Use New JuMP Macro API #334

merged 10 commits into from
Feb 1, 2024

Conversation

pulsipher
Copy link
Collaborator

@pulsipher pulsipher commented Dec 12, 2023

This tries out jump-dev/JuMP.jl#3620 as a proof of concept.

cc @odow

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ad13a33) 99.76% compared to head (f78eabe) 99.74%.

Files Patch % Lines
src/macros.jl 98.79% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage   99.76%   99.74%   -0.02%     
==========================================
  Files          36       36              
  Lines        6680     6589      -91     
==========================================
- Hits         6664     6572      -92     
- Misses         16       17       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Contributor

odow commented Dec 12, 2023

The 1.6 failure is our fault, because we don't have <0.0.1 here: https://github.com/jump-dev/JuMP.jl/blob/5b1a53f0a5adb7028ec2356f6239657a21475891/Project.toml#L24

@pulsipher
Copy link
Collaborator Author

The 1.6 failure is our fault, because we don't have <0.0.1 here: https://github.com/jump-dev/JuMP.jl/blob/5b1a53f0a5adb7028ec2356f6239657a21475891/Project.toml#L24

Ok, I'll wait for the fix then.

@odow
Copy link
Contributor

odow commented Dec 13, 2023

Ok, I'll wait for the fix then.

It's just because you're using Pkg in the tests. This is a bug in Julia 1.6. When we tag a release of JuMP it'll work.

Edit: I guess it doesn't hurt: jump-dev/JuMP.jl#3626

@odow
Copy link
Contributor

odow commented Dec 13, 2023

Hopefully fixed, so try re-running the tests.

@pulsipher
Copy link
Collaborator Author

Hopefully fixed, so try re-running the tests.

That seems to have fixed it, thanks!

@pulsipher pulsipher changed the title [WIP] Test New JuMP Macro API Use New JuMP Macro API Feb 1, 2024
@pulsipher pulsipher merged commit f1b41c2 into master Feb 1, 2024
8 of 10 checks passed
@pulsipher pulsipher deleted the macro_refactor branch February 1, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simplification Simplify the underlying complexity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants