Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(examples): add writeAdvanced.js example #229

Merged
merged 12 commits into from
Aug 3, 2020
Merged

docs(examples): add writeAdvanced.js example #229

merged 12 commits into from
Aug 3, 2020

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Aug 1, 2020 •
edited
Loading

This PR adds self-explaining writeAdvanced.js example that shows and demonstrates advanced write options + adds a couple of fixes and corrections that makes the example better to understand + improves tests.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • yarn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@sranka sranka force-pushed the example/write_advanced branch from a3f2c1b to c62bb8a Compare August 2, 2020 04:18
@sranka sranka marked this pull request as ready for review August 2, 2020 10:30
@sranka sranka requested a review from vlastahajek August 2, 2020 18:26
vlastahajek
vlastahajek approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@vlastahajek vlastahajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! 👍

@sranka sranka merged commit e4c596f into master Aug 3, 2020
@sranka sranka deleted the example/write_advanced branch August 3, 2020 07:11
@bednar bednar added this to the 1.6.0 milestone Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlastahajek vlastahajek vlastahajek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sranka @vlastahajek @bednar