Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Unify default retry strategy settings across all InfluxDB v2 clients #233

Merged
merged 7 commits into from
Aug 12, 2020

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Aug 11, 2020

This PR changes the default retry strategy options:

  • initial/minimum retry delay is 5 seconds
  • max retry delay is 180 seconds
  • at most 3 retries
  • the base for the exponential backoff is set to 5 seconds, the default retry delays are now [5, 25, 125] seconds + jitter.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • yarn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@sranka sranka changed the title feat(core): unify retry strategy settings across all InfluxDB clients feat(core): Unify retry strategy settings across all InfluxDB clients Aug 11, 2020
@sranka sranka changed the title feat(core): Unify retry strategy settings across all InfluxDB clients feat(core): Unify default retry strategy settings across all InfluxDB clients Aug 11, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2020

Codecov Report

Merging #233 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #233   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines          940       940           
  Branches       201       201           
=========================================
  Hits           940       940           
Impacted Files Coverage Δ
packages/core/src/options.ts 100.00% <ø> (ø)
packages/core/src/impl/retryStrategy.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bde913...729873b. Read the comment docs.

@sranka sranka self-assigned this Aug 11, 2020
@sranka sranka requested review from bednar and vlastahajek August 11, 2020 15:20
@sranka sranka marked this pull request as ready for review August 11, 2020 15:21
@sranka sranka changed the title feat(core): Unify default retry strategy settings across all InfluxDB clients feat(core): Unify default retry strategy settings across all InfluxDB v2 clients Aug 11, 2020
@sranka sranka force-pushed the feat/common_retry branch from 44c85a7 to 84cc4ed Compare August 11, 2020 19:29
Copy link
Contributor

@vlastahajek vlastahajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sranka sranka force-pushed the feat/common_retry branch from a552382 to 729873b Compare August 12, 2020 07:11
@sranka sranka merged commit bb76bfe into master Aug 12, 2020
@sranka sranka deleted the feat/common_retry branch August 12, 2020 07:27
@bednar bednar added this to the 1.6.0 milestone Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants