Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update query example #429

Merged
merged 2 commits into from
Apr 6, 2022
Merged

docs: update query example #429

merged 2 commits into from
Apr 6, 2022

Conversation

hoorayimhelping
Copy link
Contributor

@hoorayimhelping hoorayimhelping commented Apr 6, 2022

Proposed Changes

While using the JS client in our firstMile work, I copied the code from the example and kept running into syntax errors. After I changed to the code to look the way this updated example looks, it started working properly.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • yarn test completes successfully
  • Commit messages are in semantic format

@sranka
Copy link
Contributor

sranka commented Apr 6, 2022

Thank you @hoorayimhelping for posting an issue. The only difference in the proposed change is the meaning of this in the callbacks. The meaning of this is a kind of JS pain that the programmers need not be aware of when they stick to arrow functions. So this PR sounds like a reasonable enhancement. I will update all the examples so that they are better for copy-pasting.

@sranka sranka merged commit 205719d into master Apr 6, 2022
@sranka sranka deleted the bucky_update_query_example branch April 6, 2022 15:08
@bednar bednar added this to the 1.25.0 milestone Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants