Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): allow custom transport options in a browser #447

Merged
merged 2 commits into from
May 19, 2022

Conversation

sranka
Copy link
Contributor

@sranka sranka commented May 19, 2022

Fixes #446 . Custom transport options are herein also accepted in a browser environment.

For example: to change the credentials option from a default omit to include :

new InfluxDB({
  url,
  token,
  transportOptions: {credentials: 'include'},
})

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • yarn test completes successfully

@sranka sranka requested a review from bednar May 19, 2022 02:19
@sranka sranka added this to the 1.26.0 milestone May 19, 2022
@sranka sranka requested a review from vlastahajek May 19, 2022 02:21
@sranka sranka changed the title feat(core): use custom transport options in a browser feat(core): allow custom transport options in a browser May 19, 2022
@sranka sranka marked this pull request as ready for review May 19, 2022 02:21
@codecov-commenter
Copy link

Codecov Report

Merging #447 (47f2f6c) into master (3f59bcb) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #447   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        33           
  Lines         1234      1234           
  Branches       292       292           
=========================================
  Hits          1234      1234           
Impacted Files Coverage Δ
packages/core/src/impl/browser/FetchTransport.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f59bcb...47f2f6c. Read the comment docs.

@sranka sranka merged commit 1f1deed into master May 19, 2022
@sranka sranka deleted the 446/fetch_custom_options branch May 19, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookies omitted from request
3 participants