-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): switch to esbuild #511
Conversation
Codecov Report
@@ Coverage Diff @@
## master #511 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 33 33
Lines 1256 1256
Branches 302 302
=========================================
Hits 1256 1256
Continue to review full report at Codecov.
|
All examples were tried manually as well as the built files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍻
This PR modernizes the client build system to transpile the source code with esbuild. The client build time is thus reduced to 40% of the original time with equivalent build results.
More specifically:
rollup
(withtsc
compiler) with tsup (relies uponesbuild
instead)tsup
still usestsc
compiler to produce typescript definition files (index.d.ts
), there is no support to do so directly with esbuild (and also swc)esbuild
is customized in order toesbuild
OOTB; UMD builds are still required in older build pipelines and web workersChecklist
yarn test
completes successfully