Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): repair import URL in the browser example #590

Merged
merged 5 commits into from
Sep 29, 2022

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Sep 29, 2022

Proposed Changes

  • browser import of @influxdata/influxdb-client-apis is fixed, it ceased to work after upgrading the build system to esbuild
  • InfluxDB environment configuration is moved to a module file, it looks better than using a window object
  • the configured bucket is used also in the pre-defined query
  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tested manually
  • yarn test completes successfully
  • Commit messages are conventional

@codecov-commenter
Copy link

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (46da341) compared to base (48d6857).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #590   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        33           
  Lines         1273      1273           
  Branches       306       306           
=========================================
  Hits          1273      1273           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sranka sranka marked this pull request as ready for review September 29, 2022 12:32
@sranka sranka merged commit 3563aea into master Sep 29, 2022
@sranka sranka deleted the fix/browser_example branch September 29, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants