Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Azure Monitor input plugin #10103

Merged
merged 58 commits into from
Nov 16, 2022

Conversation

ShiranAvidov
Copy link
Contributor

Required for all PRs:

resolves #7930

@sjwang90 sjwang90 added the cloud Issues or requests around cloud environments label Nov 24, 2021
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShiranAvidov thanks for the interesting PR! Beside the comments in the code, I have a more general comment_:
Please try to simplify the code (e.g. by doing the init-stuff sequentially) and try to maybe reorganize the code to multiple files e.g. for the structures or helper-functions. This would ease the review and later working with the code as the current code base is rather large compared to other plugins.

Looking forward to the next round. :-)

@srebhan srebhan self-assigned this Dec 6, 2021
@ShiranAvidov
Copy link
Contributor Author

Hi @srebhan,
I changed the code according your comments.

Happy holidays :)

@powersj
Copy link
Contributor

powersj commented Jan 4, 2022

@ShiranAvidov if you could please rebase on master and resolve the conflicts with go.mod that would help keep this PR moving.

Thanks!

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at the code, I wonder why you cannot use the Azure-SDK for go instead of directly working with the URLs. If you scroll down you find API packages for resources/resource groups as well as substriptions...

Any reason you do not use those? They even do have examples...

@ShiranAvidov
Copy link
Contributor Author

@srebhan done.

@ZPascal
Copy link
Contributor

ZPascal commented Sep 28, 2022

@srebhan Are there still open points from your side? Is the PR mergeable?

@powersj
Copy link
Contributor

powersj commented Oct 12, 2022

@srebhan I think this one looks good and is ready. It does not have the sample config structure we use now, were you planning to do that in a follow up?

@powersj powersj requested a review from srebhan October 17, 2022 20:30
@ZPascal
Copy link
Contributor

ZPascal commented Oct 24, 2022

@srebhan Any news from your side?

@ZPascal
Copy link
Contributor

ZPascal commented Nov 8, 2022

@powersj Is there the possibility to rebase and merge it? We want to consume the new functionality.

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Sorry for the late reply... Thanks for all your effort @ShiranAvidov and @ZPascal!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 15, 2022
@srebhan
Copy link
Member

srebhan commented Nov 15, 2022

@ZPascal can you please resolve the remaining conflict?

@powersj
Copy link
Contributor

powersj commented Nov 15, 2022

I just pushed to resolve the go.sum conflict, let's see if tests pass

@powersj
Copy link
Contributor

powersj commented Nov 15, 2022

please run go mod tidy and check in changes, you might have to use the same version of Go as the CI

Doesn't look like it, so still need you to push an update after running go mod tidy

@powersj
Copy link
Contributor

powersj commented Nov 16, 2022

@srebhan can you re-reivew, I've cleaned up linter issues, ran make tidy, and moved the sample config out

@powersj powersj requested a review from srebhan November 16, 2022 17:07
@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for all the work @ShiranAvidov and @powersj!

@srebhan srebhan merged commit 7ef5993 into influxdata:master Nov 16, 2022
@ZPascal
Copy link
Contributor

ZPascal commented Nov 16, 2022

@powersj Thank you for handling the merge conflicts. Also, from side thank you, @ShiranAvidov @srebhan @powersj for the review, the feature and the invested work to deliver the functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud Issues or requests around cloud environments feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input Plugin for Azure Monitor
7 participants