-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Azure Monitor input plugin #10103
feat: Add Azure Monitor input plugin #10103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShiranAvidov thanks for the interesting PR! Beside the comments in the code, I have a more general comment_:
Please try to simplify the code (e.g. by doing the init-stuff sequentially) and try to maybe reorganize the code to multiple files e.g. for the structures or helper-functions. This would ease the review and later working with the code as the current code base is rather large compared to other plugins.
Looking forward to the next round. :-)
Hi @srebhan, Happy holidays :) |
@ShiranAvidov if you could please rebase on master and resolve the conflicts with Thanks! |
📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking at the code, I wonder why you cannot use the Azure-SDK for go instead of directly working with the URLs. If you scroll down you find API packages for resources/resource groups as well as substriptions...
Any reason you do not use those? They even do have examples...
@srebhan done. |
@srebhan Are there still open points from your side? Is the PR mergeable? |
@srebhan I think this one looks good and is ready. It does not have the sample config structure we use now, were you planning to do that in a follow up? |
@srebhan Any news from your side? |
@powersj Is there the possibility to rebase and merge it? We want to consume the new functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Sorry for the late reply... Thanks for all your effort @ShiranAvidov and @ZPascal!
@ZPascal can you please resolve the remaining conflict? |
I just pushed to resolve the go.sum conflict, let's see if tests pass |
Doesn't look like it, so still need you to push an update after running |
@srebhan can you re-reivew, I've cleaned up linter issues, ran make tidy, and moved the sample config out |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for all the work @ShiranAvidov and @powersj!
@powersj Thank you for handling the merge conflicts. Also, from side thank you, @ShiranAvidov @srebhan @powersj for the review, the feature and the invested work to deliver the functionality. |
Required for all PRs:
resolves #7930