Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.kubernetes): refresh token from file at each read #11578

Merged
merged 3 commits into from
Aug 3, 2022
Merged

fix(inputs.kubernetes): refresh token from file at each read #11578

merged 3 commits into from
Aug 3, 2022

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Aug 1, 2022

Similar to #11267, this allows for the token contained in the provided
file to get re-read at each interval. This way, if the token is
updated/refreshed Telegraf will also get the newer token.

powersj added 2 commits August 1, 2022 11:47
@powersj
fix (inputs/kubernetes): refresh token from file at each read
1ba30db 
Similar to influxdata#11267, this allows for the token contained in the provided
file to get re-read at each interval. This way if the token is
updated/refreshed Telegraf will also get the newer token.
@powersj
fix docs
6770757
@powersj powersj changed the title fix (inputs/kubernetes): refresh token from file at each read fix(inputs/kubernetes): refresh token from file at each read Aug 1, 2022
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Aug 2, 2022

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@powersj powersj marked this pull request as ready for review August 2, 2022 21:29
srebhan
srebhan approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @powersj for the fix!

@srebhan srebhan self-assigned this Aug 3, 2022
@srebhan srebhan added fix pr to fix corresponding bug area/k8s plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Aug 3, 2022
@srebhan srebhan changed the title fix(inputs/kubernetes): refresh token from file at each read fix(inputs.kubernetes): refresh token from file at each read Aug 3, 2022
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 3, 2022
@reimda
Copy link
Contributor

reimda commented Aug 3, 2022

It looks like this is related to secret store functionality. If the secret store could be updated by the plugin, we wouldn't need a separate external file. Once we merge secret store (see #11232) we might want to revisit kubernetes token refresh.

@reimda reimda merged commit 388be51 into influxdata:master Aug 3, 2022
@powersj powersj deleted the fix/k8s-auth-refresh branch August 3, 2022 19:11
reimda pushed a commit that referenced this pull request Aug 15, 2022
@powersj @reimda
fix(inputs.kubernetes): refresh token from file at each read (#11578)
6a31695 
(cherry picked from commit 388be51)
reimda pushed a commit that referenced this pull request Aug 16, 2022
@powersj @reimda
fix(inputs.kubernetes): refresh token from file at each read (#11578)
8717db1 
(cherry picked from commit 388be51)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reimda reimda reimda approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/k8s fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@powersj @reimda @srebhan