Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(internal.ethtool): internal name conflict with aws #11696

Merged
merged 6 commits into from
Sep 20, 2022
Merged

fix(internal.ethtool): internal name conflict with aws #11696

merged 6 commits into from
Sep 20, 2022

Conversation

MyaLongmire
Copy link
Contributor

@MyaLongmire MyaLongmire commented Aug 17, 2022 •
edited
Loading

Required for all PRs

resolves #10869

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Aug 17, 2022
@MyaLongmire MyaLongmire marked this pull request as ready for review August 17, 2022 17:42
@MyaLongmire MyaLongmire mentioned this pull request Aug 17, 2022
Closed
srebhan
srebhan reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MyaLongmire for the fix. Are we really sure the type assertion will always hold? I'd feel a bit better if we check and log on error...

@srebhan srebhan self-assigned this Aug 17, 2022
@MyaLongmire MyaLongmire marked this pull request as draft August 18, 2022 13:31
@MyaLongmire
Copy link
Contributor Author

@srebhan I am not convinced this is the correct way to implement the logger but I gave it a go. If you would please take another look :)

@srebhan
Copy link
Member

srebhan commented Sep 7, 2022

Oh damn I feel so dumb... I didn't notice that the function is in the test. :-( Sorry for all the noise!!! Please revert to before adding the logger as it is not worth to do this for tests!

@MyaLongmire
Copy link
Contributor Author

@srebhan no worries :) I have now removed the logger if you wouldn't mind giving it yet another look.

@MyaLongmire MyaLongmire marked this pull request as ready for review September 7, 2022 13:57
srebhan
srebhan reviewed Sep 8, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good except for the included custom_builderbinary. ;-D

@MyaLongmire
Copy link
Contributor Author

MyaLongmire commented Sep 8, 2022 •
edited
Loading

So weird! I have no idea where that came from. I will remove it.

@MyaLongmire MyaLongmire requested a review from srebhan September 8, 2022 18:52
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Sep 8, 2022

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -2.09 % for linux amd64 (new size: 148.6 MB, nightly size 151.7 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

srebhan
srebhan approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the fix @MyaLongmire!

@srebhan srebhan added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 20, 2022
powersj
powersj approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@powersj powersj merged commit 5f22bd1 into influxdata:master Sep 20, 2022
@MyaLongmire MyaLongmire deleted the fix/10869 branch September 20, 2022 15:45
popey pushed a commit that referenced this pull request Oct 3, 2022
@MyaLongmire
fix(internal.ethtool): avoid internal name conflict with aws (#11696)
0819ad5 
(cherry picked from commit 5f22bd1)
dba-leshop pushed a commit to dba-leshop/telegraf that referenced this pull request Oct 30, 2022
@MyaLongmire @dba-leshop
fix(internal.ethtool): avoid internal name conflict with aws (influxd…
2ba471e 
…ata#11696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inputs.ethtool expects boolean for interface_up metrics, however they're counters within ethtool.
3 participants
@MyaLongmire @srebhan @powersj