-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.diskio): Allow selecting devices by ID #11703
Conversation
I like it! What do we need to add the docs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be tested somehow?
@srebhan I think all that is waiting is doc updates and now conflicts resolved |
@powersj is this what you had in mind? |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
resolves #11685
This PR will try to resolve all given devices on Linux, i.e. follow the (potential) symlinks of each device to their native "name"/device file which is helpful when specifying disk-ids or uuids. Furthermore, the PR adds the WWID of disks as tag.
Note: All of the above will only work on Linux and only if there are no wildcards used!