-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.modbus): add pause after connect config parameter #11983
Conversation
Two checks failed:
My fault? Edit: all checks passed now. |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to put this up.
I am concerned that this will lead to a lot of "interval took too long" messages if set to high as you mention in the readme.
I am sure that users who need this feature have thought about the duration of Modbus requests beforehand. They will be able to handle it. Thank you for accepting my request. |
Required for all PRs
resolves feature request #11919
Allows to add a pause (warm-up time) for the slave device after modbus connect. E.g. Huawei solar inverter ethernet dongles need this pause to response the first request.