-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.modbus): add slave id to failing connection #12038
Conversation
This is a helpful change, but does this also actually resolve #12021? The error message the user shows is unwrapped, and I believe it is coming from the top of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @MyaLongmire!
@powersj the top of the gather connecting is not due to 1 slave having issues. That would come from a gateway device having problems connecting. In that case, he should use an alias to determine which gateway he is having problems with. I asked him to test the artifacts and recommended using an alias. |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Given the closure of the original bug I'm going to merge this :) |
(cherry picked from commit 716394e)
Required for all PRs
resolves #12021