Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.modbus): add slave id to failing connection #12038

Merged
merged 2 commits into from
Oct 20, 2022
Merged

fix(inputs.modbus): add slave id to failing connection #12038

merged 2 commits into from
Oct 20, 2022

Conversation

MyaLongmire
Copy link
Contributor

@MyaLongmire MyaLongmire commented Oct 18, 2022

Required for all PRs

resolves #12021

@telegraf-tiger telegraf-tiger bot added area/modbus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 18, 2022
@MyaLongmire MyaLongmire requested a review from srebhan October 18, 2022 09:56
@zak-pawel zak-pawel added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 18, 2022
@powersj
Copy link
Contributor

powersj commented Oct 18, 2022

This is a helpful change, but does this also actually resolve #12021? The error message the user shows is unwrapped, and I believe it is coming from the top of Gather() where there is a call to m.connect() and an unwrapped connect error.

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @MyaLongmire!

@MyaLongmire
Copy link
Contributor Author

@powersj the top of the gather connecting is not due to 1 slave having issues. That would come from a gateway device having problems connecting. In that case, he should use an alias to determine which gateway he is having problems with. I asked him to test the artifacts and recommended using an alias.

@telegraf-tiger
Copy link
Contributor

@powersj
Copy link
Contributor

powersj commented Oct 20, 2022

Given the closure of the original bug I'm going to merge this :)

@powersj powersj merged commit 716394e into influxdata:master Oct 20, 2022
dba-leshop pushed a commit to dba-leshop/telegraf that referenced this pull request Oct 30, 2022
popey pushed a commit that referenced this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modbus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[[inputs.modbus]] add slave_id in logs
4 participants