fix(inputs.vsphere): Eliminated duplicate samples #12259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powersj
reviewed
Nov 17, 2022
There was a problem hiding this comment.
Thanks for your work on this plugin and for tracking this down! Were you working with @yogeshprasad to resolve this? I'd like to ensure it resolves his issue.
While I was surprised about the panic, we can deal with that at some point in the future.
One comment about the supported versions.
|
@powersj The tests seem to fail in some unrelated plugin (sql output). |
thanks for the updates - I will re-run them or ignore them if they don't solve themselves. |
powersj
approved these changes
Dec 6, 2022
|
@srebhan no idea why the circle ci tests are in the user's org and not influxdata, but the tests failed for reasons other than this PR. |
powersj
added
the
ready for final review
srebhan
changed the title
srebhan
added
area/vsphere
plugin/input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11168 (Reporting duplicate points)
The logic for catching up with metrics that were posted late by vCenter was faulty and sometimes looked too far back in time. Made sure rounding of intervals never result in overlapping time ranges in metric queries.