-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Syslog input plugin logs remote IP to source tag #9440
Conversation
Testing with provided artifacts: Gist of syslog messages with I'm planning on rebasing this PR after #8454 is merged |
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
@thepacketgeek #8454 has been merged, do you have time to rebase this PR now? Thank you! |
Yup! I should be able to later this week 👍🏻👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @thepacketgeek! The code looks good, I only have one suggestion regarding the tests to centralize the source
tag setting instead of doing it in the metric definition.
ci/circleci: test-go-mac test failure seems unrelated:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for your effort @thepacketgeek!
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Required for all PRs:
resolves #4762
Add remote IP of syslog sender as
source
tagThis diff adds capturing of the remote IP Address (syslog sender) and adds it as a
source
tag for each Metric: