adds predefined resolution sets for export form #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awildturtok
approved these changes
Nov 23, 2022
| List<Resolution> resolutionsFlat = resolution.stream() | ||
| .flatMap(ResolutionShortNames::correspondingResolutions) | ||
| .distinct() | ||
| .toList(); |
There was a problem hiding this comment.
ich glaube set wäre hier sogar sinnvoller, du hast es ja eh schon distinct
There was a problem hiding this comment.
Es beeinflusst die Reihenfolge der DateContexts und somit die Sortierung der Zeilen in einem Export Formular ;)
There was a problem hiding this comment.
Es soll immer grob nach fein sein
| @@ -94,15 +96,20 @@ public void resolve(QueryResolveContext context) { | |||
| timeMode.resolve(context); | |||
| prerequisite = queryGroup.getQuery(); | |||
|
|
|||
| List<Resolution> resolutionsFlat = resolution.stream() | |||
There was a problem hiding this comment.
Heißt das, dass ich effektiv ein Export Formular machen kann, mit mehreren unterschiedlichen Resolutions auf einmal?
Also geschlüsselt auf Quartale, und dann noch für's ganze Jahr?
There was a problem hiding this comment.
Genau, das geht schon immer und das JupyEnd hat das auch schon immer so genutzt :)
delete-merged-branch
bot
deleted the
feature/export_new_date_stratification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.