Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History empty state #2897

Merged
merged 6 commits into from
Jan 24, 2023
Merged

History empty state #2897

merged 6 commits into from
Jan 24, 2023

Conversation

Kadrian
Copy link
Collaborator

@Kadrian Kadrian commented Jan 23, 2023

No description provided.

Comment on lines +211 to +213
app.get("/api/concepts/:id", mockAuthMiddleware, function response(req, res) {
res.sendFile(path.join(__dirname, `./concepts/${req.params.id}.json`));
});

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [a file system access](1), but is not rate-limited.
@Kadrian Kadrian requested a review from awildturtok January 23, 2023 17:06
@Kadrian Kadrian merged commit 0e851b0 into develop Jan 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the history-empty-state branch January 24, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants