Endpoint to easily search/resolve singular entities by via basic Queries #2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoniTUB
approved these changes
Feb 13, 2023
backend/src/main/java/com/bakdata/conquery/apiv1/QueryProcessor.java
Outdated
Show resolved
Hide resolved
|
|
||
| // Build query, assuming FilterValues are all of the same concept and connector. | ||
| final CQConcept cqConcept = new CQConcept(); | ||
| cqConcept.setElements(List.of(filters.get(0).getFilter().getConnector().getConcept())); |
There was a problem hiding this comment.
du könntest den connector oben schon rausholen beim distinct
Comment on lines
70
to
75
| public static record ResolveEntitiesContainer(List<FilterValue<?>> filters){ | ||
| @ValidationMethod(message = "Only one Connector is supported.") | ||
| public boolean isFiltersForSameConnector() { | ||
| return filters().stream().map(fv -> fv.getFilter().getConnector()).distinct().count() == 1; | ||
| } | ||
| } |
There was a problem hiding this comment.
Bitte in eine extra klasse packen
There was a problem hiding this comment.
Hatte vergessen die Klasse zu löschen
|
|
||
| @POST | ||
| @Path("/resolve-entities") | ||
| public Stream<Map<String, String>> resolveEntities(@Auth Subject subject, @Valid @NotEmpty List<FilterValue<?>> container, @Context HttpServletRequest request) { |
There was a problem hiding this comment.
Suggested change
| public Stream<Map<String, String>> resolveEntities(@Auth Subject subject, @Valid @NotEmpty List<FilterValue<?>> container, @Context HttpServletRequest request) { | |
| public Stream<Map<String, String>> resolveEntities(@Auth Subject subject, @Valid @NotEmpty List<FilterValue<?>> container) { |
| /** | ||
| * Execute a basic query on a single concept and return only the included entities Id's. | ||
| */ | ||
| public Stream<Map<String, String>> resolveEntities(Subject subject, List<FilterValue<?>> filters, Dataset dataset) { |
There was a problem hiding this comment.
Wir sollten echt überlegen ob wir nicht einen synchronen/long-poll execution modus anbieten.
There was a problem hiding this comment.
ja, wobei hier ja das format ja auch ein bestimmtes ist. Long-poll könnte man ja recht einfach über einen query-param in den query-submission Endpunkten machen, und dann mit der gleichen Logik wie hier.
…r.java Co-authored-by: MT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.