restructures ResultType and decouples printing into ResultPrinters: #3512

awildturtok · 2024-07-31T15:00:53Z

ResultType is now very simple mix of primitive enum and LIST. (We hope to remove even more logic from it)
Result printing was always weird with Mappings embedded in StringT. We've moved that responsibility into ResultInfo via SelectResultInfo for mapped Selects.
This PR opens the possibility to embed anonymization into the ResultInfo.
PrintSettings now caches the C10n calls as they were before that sometimes invoked per cell, which should make rendering faster.

backend/src/main/java/com/bakdata/conquery/ConqueryConstants.java

backend/src/main/java/com/bakdata/conquery/apiv1/query/concept/specific/CQAnd.java

backend/src/main/java/com/bakdata/conquery/io/result/arrow/ArrowRenderer.java

backend/src/main/java/com/bakdata/conquery/io/result/arrow/ArrowUtil.java

...d/src/main/java/com/bakdata/conquery/models/query/statistics/NumberColumnStatsCollector.java

backend/src/main/java/com/bakdata/conquery/models/query/statistics/ResultStatistics.java

backend/src/main/java/com/bakdata/conquery/sql/conversion/NodeConversions.java

backend/src/main/java/com/bakdata/conquery/sql/conversion/cqelement/ConversionContext.java

- ResultType is now very simple mix of primitive enum and LIST. (We hope to remove even more logic from it) - Result printing was always weird with Mappings embedded in StringT. We've moved that responsibility into ResultInfo via SelectResultInfo for mapped Selects. - This PR opens the possibility to embed anonymization into the ResultInfo. - PrintSettings now caches the C10n calls as they were before that sometimes invoked per cell, which should make rendering faster.

thoniTUB

Gefällt mir :)
So weit iche s gesehen habe ist jetzt noch mapping testenoffen mit den verschiedenen typen und den C10n Cache finde ich in den PrintSettings nicht so gut aufgehoben.

backend/src/main/java/com/bakdata/conquery/io/result/arrow/ArrowRenderer.java

backend/src/main/java/com/bakdata/conquery/io/result/excel/ExcelRenderer.java

backend/src/main/java/com/bakdata/conquery/io/result/parquet/EntityResultWriteSupport.java

backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/Concept.java

.../conquery/models/datasets/concepts/select/connector/specific/MappableSingleColumnSelect.java

backend/src/main/java/com/bakdata/conquery/models/query/resultinfo/printers/ResultPrinters.java

thoniTUB · 2024-08-01T06:57:17Z

...c/main/java/com/bakdata/conquery/models/query/resultinfo/printers/SecondaryIdResultInfo.java

+	@Override
+	public ColumnDescriptor asColumnDescriptor(PrintSettings settings, UniqueNamer collector) {
+		return ColumnDescriptor.builder()
+							   .label(defaultColumnName(settings))


So sollte hier passen

Suggested change

.label(defaultColumnName(settings))

.label(collector.getUniqueName(this))

ich hab hier mal aufgeräumt und asColumnDescriptor final gemacht,das war ziemliches chaos aber alles im Grunde die gleiche impl

...c/main/java/com/bakdata/conquery/models/query/resultinfo/printers/SecondaryIdResultInfo.java

...d/src/main/java/com/bakdata/conquery/models/query/statistics/StringColumnStatsCollector.java

… FeatureGroup

…or QueryStatisticsTest

backend/src/main/java/com/bakdata/conquery/apiv1/query/TableExportQuery.java

backend/src/main/java/com/bakdata/conquery/io/result/arrow/ArrowRenderer.java

backend/src/main/java/com/bakdata/conquery/models/query/PrintSettings.java

backend/src/main/java/com/bakdata/conquery/models/query/resultinfo/ResultInfo.java

backend/src/main/java/com/bakdata/conquery/models/query/resultinfo/SelectResultInfo.java

backend/src/main/java/com/bakdata/conquery/models/query/resultinfo/printers/ResultPrinters.java

…call.

…ers to records

thoniTUB

Bitte noch über die offenen Konversationen rüberschauen. Da sind noch kleine Todos

backend/src/main/java/com/bakdata/conquery/io/result/excel/ExcelRenderer.java

backend/src/main/java/com/bakdata/conquery/models/forms/util/Resolution.java

awildturtok requested a review from thoniTUB July 31, 2024 15:00

awildturtok commented Jul 31, 2024

View reviewed changes

awildturtok force-pushed the feature/decouple-printing-from-ResultTyoe branch from df3f1cc to e688d98 Compare July 31, 2024 15:31

fixes null resultType in Test

84ad761

thoniTUB reviewed Aug 1, 2024

View reviewed changes

awildturtok added 10 commits August 1, 2024 11:00

fix Printer signature

18a0bd8

minor cleanup of naming

061c9ac

fixes ResultTypeTest, brings back localized mapping of Resolution and…

92ba8d0

… FeatureGroup

adds missing ResultType to satisfy default constructor

bab8bab

unwrap ListPrinters in Arrow and Excel renderer

a3a0a42

fixes type of MappableSingleColumnSelect, and fixing type selection f…

56950fd

…or QueryStatisticsTest

Merge branch 'develop' into feature/decouple-printing-from-ResultTyoe

7645cf1

fix TypedSelectDummy holder

f152160

adds ListPrinter for ConceptColumnSelect

d2a9986

fixes DateRange header and SecondaryIdResultInfo

31de3f2

thoniTUB requested changes Aug 20, 2024

View reviewed changes

Early binds PrintSettings to avoid passing it into Printers at every …

8b2ee30

…call.

awildturtok force-pushed the feature/decouple-printing-from-ResultTyoe branch from 7f23383 to 8b2ee30 Compare August 20, 2024 11:40

awildturtok added 4 commits August 20, 2024 13:54

fixes not using Printer object for ConceptIds. Also migrate all print…

0eecef6

…ers to records

fixes StoredQueriesProcessorTest

cb0c47e

cleanup superfluous c'tor

3bd7407

cleanup superfluous PrintSettings c'tor

d4692bf

awildturtok requested a review from thoniTUB August 21, 2024 14:46

thoniTUB approved these changes Aug 21, 2024

View reviewed changes

backend/src/main/java/com/bakdata/conquery/io/result/excel/ExcelRenderer.java Outdated Show resolved Hide resolved

backend/src/main/java/com/bakdata/conquery/models/forms/util/Resolution.java Outdated Show resolved Hide resolved

awildturtok added 2 commits August 22, 2024 10:09

Cleanup Localized Printers

e95bb29

Code Style Issues and cleanup

6d03233

awildturtok requested a review from thoniTUB August 22, 2024 08:22

thoniTUB approved these changes Aug 22, 2024

View reviewed changes

Merge branch 'develop' into feature/decouple-printing-from-ResultTyoe

d8cceb5

awildturtok merged commit 0854f74 into develop Aug 22, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

restructures ResultType and decouples printing into ResultPrinters: #3512

restructures ResultType and decouples printing into ResultPrinters: #3512

awildturtok commented Jul 31, 2024

thoniTUB left a comment

thoniTUB Aug 1, 2024

awildturtok Aug 22, 2024

thoniTUB left a comment

	.label(defaultColumnName(settings))
	.label(collector.getUniqueName(this))

restructures ResultType and decouples printing into ResultPrinters: #3512

restructures ResultType and decouples printing into ResultPrinters: #3512

Conversation

awildturtok commented Jul 31, 2024

thoniTUB left a comment

Choose a reason for hiding this comment

thoniTUB Aug 1, 2024

Choose a reason for hiding this comment

awildturtok Aug 22, 2024

Choose a reason for hiding this comment

thoniTUB left a comment

Choose a reason for hiding this comment