submit ForwardToNamespace messages to the job manager of the namespace #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoniTUB
commented
Oct 1, 2024
Comment on lines
78
to
81
| if (toManagerNode instanceof ForwardToNamespace nsMesg) { | ||
| datasetRegistry.get(nsMesg.getDatasetId()).getJobManager().addSlowJob(job); | ||
| } | ||
| else if (toManagerNode instanceof SlowMessage slowMessage) { |
There was a problem hiding this comment.
@awildturtok das meinte ich mit hochziehen. ForwardToNamespace sind implizit slow messages
There was a problem hiding this comment.
ja das ist vermutlich der richtige Weg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, during Matching-Stats the manager job queue gets flooded and namespace messages are sequentially worked on for all datasets.
This dispatches the messages to the namespace.