Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mirage-xen-posix cross-compilation rule (unneeded since mirage-xen 6.0.0) #45

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

hannesm
Copy link
Collaborator

@hannesm hannesm commented Oct 27, 2020

also use a Makefile for freestanding builds (for tight control of CFLAGS), see
mirage/mirage-xen#23 for motivation and further details

while the old code and releases are as well working, this is a better (and unified) way to do this.

Copy link
Contributor

@dinosaure dinosaure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far the CI is happy, seems good to me.

…-xen 6.0.0)

also use a Makefile for freestanding builds (for tight control of CFLAGS), see
mirage/mirage-xen#23 for motivation and further details

update lower bound to dune 2.6
@hannesm
Copy link
Collaborator Author

hannesm commented Nov 2, 2020

Dear @seliopou, this is ready to being merged & released -- if you're fine with the changes (most notably: update to dune 2, require dune 2.6).

@seliopou seliopou merged commit 353cb28 into inhabitedtype:master Nov 2, 2020
@seliopou
Copy link
Member

seliopou commented Nov 2, 2020

I’ll cut a release right now before I forget.

@hannesm hannesm deleted the no-xen branch November 2, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants