Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the performance of XML operations by not calling
node.getChildNodes()
multiple times in a loop.The result of
node.getChildNodes()
should be stored in a variable before starting a for loop.I compared the performance before PR and after PR, using a Snapdragon 662+4GB RAM phone and a Snapdragon 410+2GB RAM phone
This resulted in significant improvements for some XML files, especially those with many child nodes.
In addition, I did some refactoring:
document.getDocumentElement()
I tested this change with 19.44.36, 19.16.36, and 18.29.36 and confirmed that this changes don't change the result resources.
I compared the
patched-temporary-files
dir of current patches and my PR branch patches using WinMerge and those were identical.