Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/daef 418 About page, available from the system menu #430

Merged

Conversation

tomislavhoracek
Copy link
Contributor

This PR introduces about page window from system menu.
about window

@nikolaglumac nikolaglumac changed the title Fix/daef 418 About page, available from the system menu Feature/daef 418 About page, available from the system menu Aug 22, 2017
Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomothespian great work! The only thing that bothers me is that it takes a few seconds before the about window appears on screen … do you think there is any chance to make it faster?

@nikolaglumac
Copy link
Contributor

nikolaglumac commented Aug 23, 2017

@DominikGuzei: @tomothespian and I have tried to find a way to speed it up and failed :(
The only possible way to speed it up would be to pre-generate about page in pure html. That way it would be displayed instantaneously BUT this approach has 2 pitfalls: we need theming and translations support.
In the end I don't think our About page is much slower (or at all slower) than the one from Slack ;)

@DominikGuzei
Copy link
Member

Ok thanks for the report 👍 you're right, this seems to be a problem with electron / rendering speed of the web app. It's not critical since the about page is not viewed regularly 😉

@DominikGuzei
Copy link
Member

Merging when CI is done

@darko-mijic
Copy link
Contributor

Let's not merge it until we update the list of people.

@darko-mijic darko-mijic merged commit e7b5207 into master Aug 24, 2017
@darko-mijic darko-mijic deleted the feature/daef-418-about-page-available-from-the-system-menu branch August 24, 2017 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants