Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-299] Fix TLS certificate path #454

Merged
merged 3 commits into from
Sep 1, 2017

Conversation

domenkozar
Copy link
Contributor

Testing...

@domenkozar domenkozar added the WIP label Aug 30, 2017
@mention-bot
Copy link

@domenkozar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DominikGuzei, @darko-mijic and @tomothespian to be potential reviewers.

@domenkozar
Copy link
Contributor Author

@fersel can you test win installer if certs work (and if not, paste the beginning of the daedalus log)?

@fersel
Copy link
Contributor

fersel commented Aug 30, 2017

@domenkozar certs are working correctly for the provided installer.

@fersel
Copy link
Contributor

fersel commented Aug 30, 2017

@domenkozar not so lucky with the mac one, certs are not created :

[91m[node:ERROR:ThreadId 4936] �[0m[2017-08-30 19:26:03 MSK] Reporting misbehaviour “Worker/plugin with logger name LoggerName {loggerName = “node”} failed with exception: /Users/fersel/Library/Application Support/Daedalus/tls/server/server.crt: openBinaryFile: does not exist (No such file or directory)”
�[94m[node.worker.slotting.ntp:INFO:ThreadId 4934] �[0m[2017-08-30 19:26:03 MSK] Host “time.windows.com” is resolved: 51.140.127.197:123
�[91m[node:ERROR:ThreadId 4936] �[0m[2017-08-30 19:26:03 MSK] Reporting misbehaviour “Worker/plugin with logger name LoggerName {loggerName = “node”} failed with exception: /Users/fersel/Library/Application Support/Daedalus/tls/server/server.crt: openBinaryFile: does not exist (No such file or directory)”
Rawlogs size is: 18
�[94m[node.worker.slotting.ntp:INFO:ThreadId 4934] �[0m[2017-08-30 19:26:03 MSK] Host “clock.isc.org” is resolved: 149.20.64.28:123
�[91m[node:ERROR:ThreadId 4936] �[0m[2017-08-30 19:26:03 MSK] Didn’t manage to report misbehaveour Worker/plugin with logger name LoggerName {loggerName = “node”} failed with exception: /Users/fersel/Library/Application Support/Daedalus/tls/server/server.crt: openBinaryFile: does not exist (No such file or directory) because of exception /nix/store/v529vfry3dygak9kvpig1d7dvkp9fbqg-SecurityTool-55115/bin/security: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
�[94m[node.worker.slotting.ntp:INFO:ThreadId 4934] �[0m[2017-08-30 19:26:03 MSK] Host “ntp5.stratum2.ru” is resolved: 88.147.254.234:123
�[91m[node:ERROR:ThreadId 4936] �[0m[2017-08-30 19:26:03 MSK] Didn’t manage to report misbehaveour Worker/plugin with logger name LoggerName {loggerName = “node”} failed with exception: /Users/fersel/Library/Application Support/Daedalus/tls/server/server.crt: openBinaryFile: does not exist (No such file or directory) because of exception /nix/store/v529vfry3dygak9kvpig1d7dvkp9fbqg-SecurityTool-55115/bin/security: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)

The beginning of the daedalus log:

[2017-08-30 19:25:58:0498] [info] /Applications/Daedalus.app/Contents/MacOS/tls/ca/ca.crt

Tell me if you need full log(s).

@deepfire
Copy link
Contributor

I think I know what's the problem.

@domenkozar domenkozar force-pushed the devops-299-fix-tls-cert-paths branch from e4ad17f to 252854a Compare August 30, 2017 21:29
@fersel
Copy link
Contributor

fersel commented Aug 31, 2017

@domenkozar that fixes the topology issue, thanks! The node seems to work OK now.

But now the frontend part wouldn't start because of the ReferenceError: appLogFolderPath is not defined exception.

@domenkozar domenkozar force-pushed the devops-299-fix-tls-cert-paths branch 2 times, most recently from 89e4d87 to 1490b99 Compare August 31, 2017 09:26
@fersel
Copy link
Contributor

fersel commented Aug 31, 2017

@domenkozar we're getting closer :) now I'm getting

[2017-08-31 14:36:56:0902] [error] CardanoClientApi::syncProgress error: {
  "stack": "Error: self signed certificate in certificate chain\n    at Error (native)\n    at TLSSocket.<anonymous> (_tls_wrap.js:1060:38)\n    at emitNone (events.js:86:13)\n    at TLSSocket.emit (events.js:185:7)\n    at TLSSocket._finishInit (_tls_wrap.js:584:8)\n    at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:416:38)",
  "message": "self signed certificate in certificate chain",
  "code": "SELF_SIGNED_CERT_IN_CHAIN"
}

From Daedalus.log:

[2017-08-31 14:43:37:0914] [error] Error while loading ca.crt: Error: ENOENT: no such file or directory, open '/Applications/Daedalus.app/Contents/Resources/app/dist/Applications/Daedalus.app/Contents/MacOS/tls/ca/ca.crt'

(Note that certs are being "fetched by" the node though).

@domenkozar domenkozar force-pushed the devops-299-fix-tls-cert-paths branch from 1490b99 to c29f077 Compare August 31, 2017 13:40
@domenkozar
Copy link
Contributor Author

Rebase of master broke things :) Should be fixed now.

@fersel
Copy link
Contributor

fersel commented Aug 31, 2017

@domenkozar now this:

[2017-08-31 21:26:35:0117] [info] Using certificates from: /Applications/Daedalus.app/Contents/MacOS/tls/ca/ca.crt
[2017-08-31 21:26:35:0117] [error] Error while loading ca.crt: ReferenceError: pathToCertificate is not defined

(node is ok but frontend is not working)

@domenkozar domenkozar force-pushed the devops-299-fix-tls-cert-paths branch from c29f077 to 94ce34c Compare August 31, 2017 19:51
@domenkozar
Copy link
Contributor Author

@fersel confirmed that it works.

@domenkozar domenkozar changed the title [DEVOPS-299] Try to fix TLS certificate path [DEVOPS-299] Fix TLS certificate path Sep 1, 2017
@darko-mijic
Copy link
Contributor

The code looks good to me. I have also verified that installer is now working properly on Mac @domenkozar.

@domenkozar domenkozar merged commit b40ec2d into master Sep 1, 2017
@darko-mijic darko-mijic deleted the devops-299-fix-tls-cert-paths branch September 20, 2017 12:38
@nikolaglumac nikolaglumac removed the WIP label Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants