Fix runtime builds by specifying srtool image #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
changed the title
OverOrion
reviewed
May 10, 2023
| with: | ||
| chain: ${{ matrix.runtime }} | ||
| tag: 1.66.1 |
There was a problem hiding this comment.
This is the last version which can be used on nightly, just putting it here for easier future reference.
OverOrion
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The srtool action does automatically build in the latest srtool docker image, which does no longer contain the nightly.
We can remove this patch when we can build with rust stable, but this needs a substrate update if I am not mistaken. For more info see paritytech/srtool#62