Fix for Plugin loading ends with error when bool type from the cpolic…

[sandlbn]

Fixes #758 .

Summary of changes:

• Added cpolicy.BoolRule to the gob

Testing done:

• Yes

@intelsdi-x/snap-maintainers

[andrzej-k]

@sandlbn Thanks for this fix. This changes looks fine, however it could be even better if you could add some unit test(s) for this change - possibly in control/plugin/cpolicy/node_test.go

[sandlbn]

@andrzej-k I'm gonna do that Today. 😺

[geauxvirtual]

Rebase the branch against master as master includes fix for the Go 1.4.3 testing issues.

[sandlbn]

This error never occurred on my local machine with Fedora 23 or Ubuntu 14.04 and go 1.6

[iolie@irild016 snap]$ go version
go version go1.6 linux/amd64
$uname -a
Linux irild016.cslf1.intel.com 4.4.2-301.fc23.x86_64 #1 SMP Tue Feb 23 19:00:38 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux or
Linux irild016.cslf1.intel.com 3.19.0-43-generic #49~14.04.1-Ubuntu SMP Thu Dec 31 15:44:49 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

make_test.txt

[jcooklin]

You would see the error if you tested locally with go1.4.3.
On Mon, Mar 21, 2016 at 3:45 AM Marcin Spoczynski [email protected]
wrote:

This error never occurred on my local machine with Fedora 23 or Ubuntu
14.04 and go 1.6

[iolie@irild016 snap]$ go version
go version go1.6 linux/amd64
$uname -a
Linux irild016.cslf1.intel.com 4.4.2-301.fc23.x86_64 #1
#1 SMP Tue Feb 23 19:00:38 UTC
2016 x86_64 x86_64 x86_64 GNU/Linux or
Linux irild016.cslf1.intel.com 3.19.0-43-generic #49
#49 SMP Thu Dec
31 15:44:49 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

make_test.txt
https://github.com/intelsdi-x/snap/files/181875/make_test.txt

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly or view it on GitHub
#759 (comment)

[sandlbn]

@jcooklin it's happening with go1.6 on the travis infra., I already rebased my PR to fix the problem with go 1.4.3 .

[geauxvirtual]

Please rebase the commit to start with Fix #758:

[geauxvirtual]

Commit message needs to start with Fix #758:

[jcooklin]

@sandlbn: After the commit message is updated as @geauxvirtual suggested above this LGTM.
Note: #801 relates to this PR (if it merges first you will need to update your GOB registrations).

[sandlbn]

@jcooklin can u merge that ?