Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service name): fix missing support for wellknown labels in tag va… #92

Merged
merged 2 commits into from
Mar 14, 2024
Merged

fix(service name): fix missing support for wellknown labels in tag va… #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dda3d2e
fix(service name): fix missing support for wellknown labels in tag va…
Umaaz Mar 14, 2024
0b91bfc
fix(service name): update CHANGELOG.md
Umaaz Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<!-- main START -->
# main (unreleased)
- **[BUGFIX]**: fix missing data in frame response [#89](https://github.com/intergral/deep/pull/89) [@Umaaz](https://github.com/Umaaz)
- **[BUGFIX]**: fix missing support for well known labels [#92](https://github.com/intergral/deep/pull/92) [@Umaaz](https://github.com/Umaaz)
<!-- main START -->

<!-- main START -->
Expand Down
7 changes: 7 additions & 0 deletions pkg/deepdb/encoding/vparquet/block_search_tags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,13 @@ func searchTagValues(ctx context.Context, tag deepql.Attribute, cb common.TagCal
return nil
}

if column, ok := wellKnownColumnLookups[tag.Name]; ok {
err := searchSpecialTagValues(ctx, column.columnPath, pf, cb)
if err != nil {
return fmt.Errorf("unexpected error searching special tags: %w", err)
}
}

// Finally also search generic key/values
err := searchStandardTagValues(ctx, tag, pf, cb)
if err != nil {
Expand Down
Loading