feat: exceptions for auth errors 400, 401, 403

[davidhuser]

related to #229

• introduce new exceptions including a factory to assign exceptions based on starlette.request type (http or websocket)
• updated the contributor guide
• fixed a minor mypy issue preventing pre-commit

[davidhuser]

failing linting tests in demo_project but these seem unrelated to this PR. How should we proceed?

[JonasKs]

I really like this, thanks!! I have some concerns about backwards compatibility, since I'd prefer not to major bump again 😁 Could we ensure that the old InvalidAuthHttp is a base? So anyone importing it, or catching it, will still catch all exceptions?

Something like this, I think would work?

class InvalidAuth(HTTPException):
    ...

class ForbiddenHttp(InvalidAuth, HTTPException):
    ...

---

failing linting tests in demo_project but these seem unrelated to this PR. How should we proceed?

Ignore. I'll look into this another time. It won't block merge 😊

[davidhuser]

Ah sure, compatibility was not on my radar. I liked your implementation idea but we would change the interface of InvalidAuth from a factory function to a class, so I thought to keep it as a factory but routing it to the new exceptions instead, example below... wdyt?

# old InvalidAuth
def InvalidAuth(detail: str, request: HTTPConnection) -> UnauthorizedHttp | UnauthorizedWebSocket:
    if request.scope['type'] == 'http':
        return UnauthorizedHttp(detail) # new exception
    return UnauthorizedWebSocket(detail) # new exception

I also tried to add a new test module specific to this.

And I added markers / TODO for the v6.0.0 release, not sure if ok!

[JonasKs]

Hey @davidhuser , so sorry for the lack of review - I'll get it done this weekend. First look looks good though, same with your implementation around exceptions and backwards compatibility! 😊

[JonasKs]

Looks very good. Thanks for also fixing CONTRIBUTING.md!! 😊

[JonasKs]

I've created a new release. Thanks again for all the effort you've put into helping me out with this library!