fix(item): matches material design character counter

[sean-perkins]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

The counter implementation for ion-item has a few differences from the MD spec. Also the counter does not consistently display to the right of the container and can run into the helper/error text when long strings are used.

Issue Number: Resolves #24334

What is the new behavior?

• Updates text color for MD to rgba(0, 0, 0, .6)
• Updates letter spacing for MD to 0.0333333em
• Updates left padding from counter to 16px
• Updates counter string to match MD 5 / 10 instead of 5/10
• Pushes counter to always display far right of the container

Does this introduce a breaking change?

• Yes
• No

Other information

Material Design specification can be found here: https://material.io/components/text-fields

[averyjohnston]

These changes look good to me, but would the new shadow parts count as feature updates? 🤔 cc @liamdebeasi

[liamdebeasi]

Yeah this is a feature change, so it would go into the feature-6.1 branch. Can we do a design doc before we merge so we can align on scope and requirements for this feature?

[sean-perkins]

Would it be worth splitting out those specific changes (and related issues) and keep this PR targeted on the visual issues with MD?

Happy to create a design doc on the shadow part changes and how they can be used/configured.

[liamdebeasi]

I think so. If we can limit this PR to the fixes noted in the linked issue and address the features for customization in a different PR, that would work with me.

[averyjohnston]

LGTM now 👍 Don't forget to update the PR description too.