fix(datetime): showing calendar grid no longer causes month to switch on ios 15 #24554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: resolves #24405
This fix is a monkey patch and should be removed when iOS 14 support is dropped in the future. There was a bug in iOS 14 where the month would move back by 1 month when switching from the month/year picker to the calendar grid. A fix was created in #24142. This fix inadvertently introduced the same issue, but only on iOS 15 and with the month moving forward by 1.
I investigated other ways to fix the iOS 14 issue, but nothing was sufficient so I opted for this hacky (and temporary!) approach. The code will apply the iOS 14 fix if it detects a WebKit browser that does not support
aspect-ratio
.aspect-ratio
was added in Safari 15: https://webkit.org/blog/11989/new-webkit-features-in-safari-15/The code will apply the normal
display: none
behavior if it detects either a non-WebKit browser or a WebKit browser that supports aspect-ratio (I.e. Safari 15+).What is the new behavior?
Does this introduce a breaking change?
Other information
Dev build: 6.0.2-dev.1641931632.6a7e2d1