fix(menu): remove main attribute that was supposed to removed in v5 #24565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
commented
Jan 12, 2022
| const content = this.contentId !== undefined | ||
| ? document.getElementById(this.contentId) | ||
| : parent && parent.querySelector && parent.querySelector('[main]'); | ||
| : null; |
There was a problem hiding this comment.
I opted for null because getElementById returns null is no element was found.
liamdebeasi
commented
Jan 12, 2022
|
|
||
| if (!content || !content.tagName) { | ||
| // requires content element | ||
| if (content === null) { |
There was a problem hiding this comment.
If content is defined as an element, then tagName is defined: https://developer.mozilla.org/en-US/docs/Web/API/Element/tagName. Nothing on MDN indicates tagName could be the empty string (which is falsy in this case)
6 tasks
sean-perkins
approved these changes
Jan 12, 2022
This was referenced Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: resolves #24563
The main attribute was removed in Ionic 5 but did not actually get removed in Ionic 5 despite being noted in the breaking changes: https://github.com/ionic-team/ionic-framework/blob/main/BREAKING.md#menu
What is the new behavior?
Does this introduce a breaking change?
Other information