Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove References to Net6 & Net7 #1349

Merged
merged 8 commits into from
Jan 22, 2025

Conversation

1eyewonder
Copy link
Contributor

These changes ensure that the projects are updated to use the latest .NET framework versions, providing improved performance and new features available in .NET 8.0 and 9.0.

@1eyewonder
Copy link
Contributor Author

Paket Lock Diff Report

This report was generated via Paket Lock Diff

Additions - (0)

Removals - (0)

Version Upgrades - (44)

Version Downgrades - (0)

@baronfel
Copy link
Contributor

@1eyewonder I think what's really happening here is the mixed-up install location. This is a pet peeve of mine, but the way the GHA runners are configured is a combination of a lot of different versions. We probably should be using an isolated install location. We should do this by setting the DOTNET_INSTALL_DIR environment variable to a known location outside of the defaults, which are described here. I suspect that with this change we'll not use any 6.x SDKs at all anymore, sidestepping this issue for us.

@1eyewonder
Copy link
Contributor Author

@1eyewonder I think what's really happening here is the mixed-up install location. This is a pet peeve of mine, but the way the GHA runners are configured is a combination of a lot of different versions. We probably should be using an isolated install location. We should do this by setting the DOTNET_INSTALL_DIR environment variable to a known location outside of the defaults, which are described here. I suspect that with this change we'll not use any 6.x SDKs at all anymore, sidestepping this issue for us.

Do we have a preference for what path we want to use for this global variable? I was just going to use something like DOTNET_INSTALL_DIR: "fsautocomplete/dotnet" if we think that will work alright. I've not tampered with this variable before so I'm unsure if there are hidden complexities.

@baronfel
Copy link
Contributor

You should be safe to choose a repo-local directory like .dotnet even - this is what all of the dotnet-org repos do for using nightly builds of the SDK and runtimes, and that's basically what we'd need to do here.

@1eyewonder
Copy link
Contributor Author

It looks like that did the trick at least for the PR build. Are we wanting to add this to other yml files as well? I imagine build-and-pack-night.yml and release.yml will need these changes too

@1eyewonder 1eyewonder marked this pull request as ready for review January 19, 2025 23:43
@baronfel
Copy link
Contributor

Yes please, that would be great

@1eyewonder
Copy link
Contributor Author

I believe this one should be ready to go. Let me know if I need to clean anything else up 🙂

Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TheAngryByrd TheAngryByrd merged commit ed1bcf7 into ionide:main Jan 22, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants