Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/memleak: Show allocation type in print_outstanding #5185

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jjyao
Copy link

@jjyao jjyao commented Jan 10, 2025

It's useful to know the allocation type when we print out the outstanding allocations.

@jjyao
Copy link
Author

jjyao commented Jan 10, 2025

@yonghong-song could you help review this one? Thanks!

@yonghong-song
Copy link
Collaborator

There is a test failure.

30/40 Test #30: py_test_tools_memleak ............***Failed    0.35 sec
  File "/bcc/tools/memleak.py", line 564
    b"\n\t\t".join(alloc.stack).decode("ascii")))
    ^
...

Please fix.

Signed-off-by: Jiajun Yao <[email protected]>
@jjyao
Copy link
Author

jjyao commented Jan 12, 2025

Fixed.

@jjyao
Copy link
Author

jjyao commented Jan 13, 2025

@yonghong-song when you get a chance, could you take another look?

Copy link
Contributor

@ekyooo ekyooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the fix commit into the previous commit to ensure the tool's functionality is not broken in every commit.

I am curious about how the output of the allocation type is useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants