Skip to content
This repository has been archived by the owner on Sep 22, 2021. It is now read-only.

fix the install documentation, one final time #18

Merged
merged 2 commits into from
Aug 16, 2018
Merged

fix the install documentation, one final time #18

merged 2 commits into from
Aug 16, 2018

Conversation

Stebalien
Copy link
Contributor

No description provided.

@ghost ghost assigned Stebalien Aug 16, 2018
@ghost ghost added the status/in-progress In progress label Aug 16, 2018
@Stebalien
Copy link
Contributor Author

We can't go-get due to gx.

Copy link
Contributor

@Mr0grog Mr0grog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Looks good to me.

@Mr0grog
Copy link
Contributor

Mr0grog commented Aug 16, 2018

Oh wait, actually, isn’t the problem in running make install, if it’s gx? Maybe we just need to say gx is a requirement, not just Go.

@Stebalien
Copy link
Contributor Author

make install should install gx. The problem here was that go get STUFF tries to get the gx dependencies and fails (because gx/ipfs/Qm... isn't a valid URL). Any package with gx "rewritten" imports isn't "go gettable". We leave most packages in the normal, non-gx form (with, e.g., github.com/... imports) for this reason. However, we leave go-ipfs in the rewritten form to prevent users from installing IPFS with go get github.com/ipfs/go-ipfs/cmd/ipfs (as they'd end up with the wrong dependency versions). This package needs to use gx/... paths as it depends on go-ipfs.

See: ipfs/kubo#4831

@Stebalien
Copy link
Contributor Author

(I've updated them per CR by @bmuller)

@Stebalien Stebalien merged commit 1a77c39 into master Aug 16, 2018
@ghost ghost removed the status/in-progress In progress label Aug 16, 2018
@Mr0grog
Copy link
Contributor

Mr0grog commented Aug 16, 2018

Ohhhh, gotcha. That makes perfect sense.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants