This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: swarm addrs test #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the common factory creates a node with no bootstrap nodes then getting a list of swarm addresses could be empty (or could also be empty anyway if the connection to the bootstrap nodes takes a long time). This PR spawns and connects another IPFS node to ensure that there should be swarm addresses available. License: MIT Signed-off-by: Alan Shaw <[email protected]>
ghost
assigned 
vasco-santos
suggested changes
Apr 4, 2019
src/swarm/addrs.js
Outdated
| }) | ||
| }) | ||
| }) | ||
|
|
||
| after((done) => common.teardown(done)) | ||
|
|
||
| it('should get a list of node addresses', (done) => { | ||
| ipfs.swarm.addrs((err, multiaddrs) => { | ||
| ipfsA.swarm.addrs((err, multiaddrs) => { |
There was a problem hiding this comment.
Should we change multiaddrs to peers or peersInfo?
I was not understanding the forEach validation, but after getting into the code, I noticed that in fact ipfs.swarm.addrs() returns an array of PeerInfo. This way, calling this multiaddrs seems confusing. I think we should also update in the SPEC
There was a problem hiding this comment.
I changed to peerInfos as there's already precedent for that name in swarm.peers docs.
License: MIT Signed-off-by: Alan Shaw <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the common factory creates a node with no bootstrap nodes then getting a list of swarm addresses could be empty (or could also be empty anyway if the connection to the bootstrap nodes takes a long time). This PR spawns and connects another IPFS node to ensure that there should be swarm addresses available.