fix: remove clean documentation theme #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vmx
reviewed
Feb 25, 2019
src/docs/build.js
Outdated
| @@ -69,7 +69,7 @@ function build (ctx) { | |||
| if (fmt === 'html') { | |||
| return documentation.build(files, getOpts(pkg)) | |||
| .then((docs) => documentation.formats.html(docs, { | |||
| theme: require.resolve('clean-documentation-theme'), | |||
| // theme: require.resolve('clean-documentation-theme'), | |||
vasco-santos
approved these changes
Feb 25, 2019
vmx
approved these changes
Feb 25, 2019
|
the merge will include the why |
|
Temporarily right because the docs command uses it? |
|
We might just use the default one. These docs aren't used much it's mostly readme docs. |
|
i think im gonna cancel this because documentation.js itself depends on highlight.js ... |
|
Perhaps it would be good to do a pilot of shrinkwrap for aegir, #330. It would solve this kind of problem, and since it's a dev dependency would be a good project to run a pilot on. |
|
closing this, problem was fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean-documentation-theme depends on highlight.js which is breaking all
npm irun this PR removes clean-documentation-theme