-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump bitswap message package to v1 #212
Conversation
This resolves issues registering protobufs from bitswap in go-libipfs when protobufs from go-bitswap are also registered in the same process.
3c2dfea
to
16aae8a
Compare
Codecov Report
@@ Coverage Diff @@
## main #212 +/- ##
==========================================
+ Coverage 30.01% 31.18% +1.17%
==========================================
Files 101 101
Lines 11312 11499 +187
==========================================
+ Hits 3395 3586 +191
+ Misses 7549 7540 -9
- Partials 368 373 +5
|
I tested this as follows:
prior to this change, that panics like we have seen
After the change it succeeds:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is stupid to begin with, I don't like it, but it works and I don't think it's gonna break anyone.
This resolves issues registering protobufs from bitswap in go-libipfs when protobufs from go-bitswap are also registered in the same process.
We should really get off of gogoproto, the whole project is deprecated, but that is a larger effort.