fix(gateway): update DoH resolver for .eth DNSLink #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare decomissionned their resolver and started redirecting (HTTP 308) to https://dns.eth.link/dns-query which is an alias for eth.limo. We change default to https://dns.eth.limo/dns-query to avoid redirects and cache splitting. Closes #771
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #781 +/- ##
==========================================
- Coverage 60.47% 60.46% -0.01%
==========================================
Files 245 245
Lines 31133 31133
==========================================
- Hits 18829 18826 -3
- Misses 10629 10630 +1
- Partials 1675 1677 +2
|
lidel
changed the title
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jan 7, 2025
2 tasks
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jan 14, 2025
commit from main branch that includes: ipfs/boxo#645 ipfs/boxo#782 ipfs/boxo#781
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jan 14, 2025
* fix(dns): update default DNSLink resolvers Depends on - ipfs/boxo#781 - ipfs/boxo#782 * chore: latest boxo main and go-doh-resolver v0.5.0 makes error message better, informing which URL failled * chore: p2p-forge v0.2.1+ this removes acmez/v2 and fixes go vet * chore: latest boxo with DoH fixes commit from main branch that includes: ipfs/boxo#645 ipfs/boxo#782 ipfs/boxo#781
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jan 14, 2025
* fix(dns): update default DNSLink resolvers Depends on - ipfs/boxo#781 - ipfs/boxo#782 * chore: latest boxo main and go-doh-resolver v0.5.0 makes error message better, informing which URL failled * chore: p2p-forge v0.2.1+ this removes acmez/v2 and fixes go vet * chore: latest boxo with DoH fixes commit from main branch that includes: ipfs/boxo#645 ipfs/boxo#782 ipfs/boxo#781 (cherry picked from commit b021a00)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloudflare decommissioned their resolver and started redirecting (HTTP 308) to https://dns.eth.link/dns-query which is an alias for eth.limo.
We change default to https://dns.eth.limo/dns-query to avoid redirects and cache splitting.
Closes #771 by implementing option (C)