add warning when no bootstrap in config #5445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Kejie Zhang <[email protected]>
|
Hi @lgierth @Stebalien , I have added a warning when no bootsrap in config , aimed to solving issue #4576 . Please help me review it , if you have any advice or anything needed to update,please ping me.Thx a lot. |
Stebalien
requested changes
Sep 10, 2018
core/bootstrap.go
Outdated
| @@ -117,7 +117,9 @@ func bootstrapRound(ctx context.Context, host host.Host, cfg BootstrapConfig) er | |||
| // get bootstrap peers from config. retrieving them here makes | |||
| // sure we remain observant of changes to client configuration. | |||
| peers := cfg.BootstrapPeers() | |||
|
|
|||
| if len(peers) == 0 { | |||
| log.Warning("no bootstrap in the configuration file") | |||
There was a problem hiding this comment.
I'd say something like:
no bootstrap nodes configured: go-ipfs may have difficulty connecting to the network
Technically, IPFS can still work if there are other IPFS nodes on the local network but this is still a good warning to have.
License: MIT Signed-off-by: Kejie Zhang <[email protected]>
|
@Stebalien Thx a lot for your suggestion,and i have updated my pr.Can u help me review again? |
Stebalien
approved these changes
Sep 11, 2018
Stebalien
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature #4576
License: MIT
Signed-off-by: Kejie Zhang [email protected]