Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v1.3.0 #25

Merged
merged 1 commit into from
Mar 7, 2022
Merged

release v1.3.0 #25

merged 1 commit into from
Mar 7, 2022

Conversation

willscott
Copy link
Collaborator

  • updated 'AsLargeBytes` method for partial reads of UnixFS files.

@willscott willscott requested a review from mvdan March 3, 2022 11:12
@github-actions
Copy link

github-actions bot commented Mar 3, 2022

Suggested version: v1.3.0
Comparing to: v1.2.0 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# github.com/ipfs/go-unixfsnode/data/builder
## incompatible changes
BuildUnixFSDirectory: changed from func([]*github.com/ipld/go-codec-dagpb._PBLink, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, error) to func([]*github.com/ipld/go-codec-dagpb._PBLink, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, uint64, error)
BuildUnixFSDirectoryEntry: changed from func(string, int64, github.com/ipld/go-ipld-prime/datamodel.Link) (*github.com/ipld/go-codec-dagpb._PBLink, error) to func(string, int64, github.com/ipld/go-ipld-prime/datamodel.Link) (*github.com/ipld/go-codec-dagpb._PBLink, error)
BuildUnixFSFile: changed from func(io.Reader, string, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, uint64, error) to func(io.Reader, string, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, uint64, error)
BuildUnixFSRecursive: changed from func(string, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, uint64, error) to func(string, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, uint64, error)
BuildUnixFSShardedDirectory: changed from func(int, uint64, []*github.com/ipld/go-codec-dagpb._PBLink, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, error) to func(int, uint64, []*github.com/ipld/go-codec-dagpb._PBLink, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, uint64, error)
BuildUnixFSSymlink: changed from func(string, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, uint64, error) to func(string, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, uint64, error)
MapAssembler.AssembleEntry: changed from func(string) (github.com/ipld/go-ipld-prime/datamodel.NodeAssembler, error) to func(string) (github.com/ipld/go-ipld-prime/datamodel.NodeAssembler, error)
MapAssembler.Finish: changed from func() error to func() error
error: changed from interface{Error() string} to uint64

# github.com/ipfs/go-unixfsnode/file
## incompatible changes
LargeBytesNode.AsLargeBytes: added
Reader.Read, method set of StreamableByteNode: removed
StreamableByteNode: removed
## compatible changes
LargeBytesNode: added

# summary
Cannot suggest a release version.
Incompatible changes were detected.

gocompat says:

(empty)

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willscott willscott merged commit 4856281 into main Mar 7, 2022
@willscott willscott deleted the release/v1.3 branch March 7, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants