wss:// gets redirected to IPNS

[mkg20001]

When accessing https://libp2p-nodetrust.tk/demo it gets properly redirected to http://127.0.0.1:8080/ipns/libp2p-nodetrust.tk/demo/
When launching the demo it connects to wss://libp2p-nodetrust.tk which should not be redirected, yet it gets redirected to http://127.0.0.1:8080/ipns/libp2p-nodetrust.tk/demo/ which breaks the demo

Fix: Detect and don't modify websocket requests

[lidel]

Thank you for reporting this.
Just to confirm, does it happen only when dnslink experiment is enabled?

[mkg20001]

Just tested it, the results look weird. i'll retest it on a clean firefox profile again.

| -                 | ff  | chrome |
|-------------------|-----|--------|
| with dnslink      | [ ] | [x]    |
| without dnslink   | [ ] | [x]    |
| without companion |     | [x]    |

[mkg20001]

On the nightly indeed everything seems to work...

| -                 | ff  | chrome |
|-------------------|-----|--------|
| with dnslink      | [x] | [x]    |
| without dnslink   | [x] | [x]    |
| without companion | [x] | [x]    |

[lidel]

I was able to replicate it yesterday with Firefox 59, but only when dnslink was enabled.
@mkg20001 did you change the web app by any chance? I am no longer able to replicate the bug today – page seems to work file with and without dnslink.

Anyway, some plausible explanations:

• The extension was breaking the WSS in by replacing initial HTTP GET that was supposed to end with 101 Switching Protocols (upgrade to websocket connection) with a plain HTTP 307 redirect to IPNS page at localhost (I am low key assuming your app used implicit hostname for websocket handshake here)
• The HTML and JS loaded from IPNS was an older (broken?) version than the one at https://libp2p-nodetrust.tk/demo.
• Upstream difference between API implementation across browser vendors. Namely the websocket protocol upgrade being handled in a different way by webRequest APIs.

I agree with general suggestion. To be on the safe side the extension should explicitly skip requests related to WSS (HTTP2IPFS gateways do not support WSS anyway). That way we will be immune to ephemeral bugs caused by browsers including/excluding websocket handshake from <all_urls> etc.

FYSA right now, both Chrome and Firefox (nightly and stable) include it in mentioned scope and pass it to both hooks:

Firefox	Chrome

To address this, I created a PR: Skip HTTP GET of websocket handshake #472

[lidel]

@mkg20001 should be fixed in latest beta (v2.2.2.9120)