Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proxy access dialog display issue on Firefox #427

Merged
merged 1 commit into from
Mar 21, 2018
Merged

fix: proxy access dialog display issue on Firefox #427

merged 1 commit into from
Mar 21, 2018

Conversation

alanshaw
Copy link
Member

I noticed this was still happening despite the previous "fix". I move the code for the fix into the page JS and it worked.

@alanshaw alanshaw requested a review from lidel March 21, 2018 11:59
lidel
lidel approved these changes Mar 21, 2018
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be that old workaround did not fix things on OSX for some reason.
Anyway, 👍 from me (still works on FF59 on Linux)

@alanshaw just for the record, are you running Firefox 59?

@lidel lidel merged commit 1f63d26 into ipfs:master Mar 21, 2018
@alanshaw alanshaw deleted the fix/dialog-display-on-ff branch March 21, 2018 14:47
@alanshaw
Copy link
Member Author

I'm on 60 right now...I think somewhere along the line I switched to the beta channel...

@lidel
Copy link
Member

lidel commented Mar 21, 2018

Yeah a lot of people switched to Beta for some reason.. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanshaw @lidel