Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: go-ipfs v0.4.23 #1329

Merged
merged 7 commits into from
Jan 31, 2020
Merged

chore: go-ipfs v0.4.23 #1329

merged 7 commits into from
Jan 31, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented Jan 21, 2020 •
edited
Loading

  • Smoke-test v0.4.23-rc1
  • Fix snap build on Linux
  • Switch CI to the current Node LTS
  • Switch this PR to v0.4.23 when ships (Release v0.4.23 kubo#6837)
  • Fix E2E tests on CI (Mac)

lidel added 2 commits January 21, 2020 22:24
@lidel
feat: go-ipfs-0.4.23-rc1
81996c1 
License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@lidel
fix(cid): update snapd before use
7a45c54 
License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@lidel lidel force-pushed the feat/go-ipfs-v0.4.23 branch from 56d3614 to 7a45c54 Compare January 23, 2020 10:07
@hacdias
Copy link
Member

hacdias commented Jan 27, 2020

Shouldn't we get the new CTL too?

@lidel
chore: switch to release version go-ipfs v0.4.23
92f45a6 
License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@lidel
Copy link
Member Author

lidel commented Jan 30, 2020 •
edited
Loading

@hacdias good question. I'd like to keep bugfix release small and don't touch CTL if we don't need to.

Does npm run test:e2e break on your Mac, or is this problem limited to CI?

Update: re-running the Mac job fixed it, so I think we just need to increase timeouts when running on Mac and CI

lidel added 4 commits January 31, 2020 13:03
@lidel
fix(ci): increase e2e tests timeout
74741fa 
Mac workers seem to be really slow and timeout at random places

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@lidel
fix(e2e): use random free ports in e2e
dc46dfd 
This ensures we don't get false-negatives on shared envs

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@lidel
fix(e2e): await config changes to be saved
bf261a3 
License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@lidel
fix(e2e): manual exit if app.stop() is too slow
c8da6f3 
License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@hacdias hacdias marked this pull request as ready for review January 31, 2020 17:19
@hacdias hacdias merged commit fa1b906 into master Jan 31, 2020
@hacdias hacdias deleted the feat/go-ipfs-v0.4.23 branch January 31, 2020 17:19
@lidel
Copy link
Member Author

lidel commented Jan 31, 2020 •
edited
Loading

@hacdias we should make v0.10.3 release with this, but I don't want to distract you in the every time we need to make a release. Could you tech me how to do a new release? :-)

Is the process documented at https://github.com/ipfs-shipyard/ipfs-desktop#releasing still valid? If not, mind updating it?

Can you give me some tips&access to do:

  • Update Homebrew Cask.
  • Update Chocolatey package.

@hacdias
Copy link
Member

hacdias commented Feb 3, 2020

@lidel I won't be available this week (will be without a computer). The process is still valid. Anyone can update the cask, just follow the linked tutorial :)

For the chocolatey: please create an account at https://chocolatey.org/ first and lemme know your username/email.

@lidel
Copy link
Member Author

lidel commented Feb 4, 2020 •
edited
Loading

@hacdias done, I am https://chocolatey.org/profiles/lidel, messaged you on Chocolatey as well

@hacdias
Copy link
Member

hacdias commented Feb 12, 2020

@lidel just added you as a maintainer. It says it's pending approval (?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lidel @hacdias