use CIDv1 in NFT guide #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnymatthews
approved these changes
Mar 23, 2021
|
I think we should take special care for EVERY URI used in docs to resolve, because if someone pastes it to Brave and gets error, the trust in IPFS is decreased. Some URIs are broken (i think due to filename change), for example:
@yusefnapora are you still in the zone to make another pass and fix this? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the CIDs in the examples for the NFT minting guide to use CIDv1 instead of V0 (
bafy...instead ofQm...), which plays nicer with web browsers and is generally what we want to recommend as "best practice".@lidel made a PR to minty to make the switch there that I just merged in, so this just makes the guide consistent with the code.
closes #707