fix: non unixfs on files #1115
Merged
fix: non unixfs on files #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <[email protected]>
License: MIT Signed-off-by: Henrique Dias <[email protected]>
fsdiogo
suggested changes
Aug 16, 2019
fsdiogo
reviewed
Aug 16, 2019
License: MIT Signed-off-by: Henrique Dias <[email protected]>
hacdias
force-pushed
the
fix/non-unixfs-on-files
branch
from
010e190 to
b576f1b
Compare
This was referenced Aug 19, 2019
lidel
reviewed
Aug 20, 2019
| const stats = await ipfs.files.stat(path) | ||
| return stats | ||
| } catch (e) { | ||
| if (e.toString().toLowerCase().includes('unixfs')) { |
There was a problem hiding this comment.
This turned out to not be robust enough.
I have old repo with various weird stuff in it and it breaks the pin screen due to error messages without unixfs:
I proposed a robust fix in #1121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1095.
Clicking on the item goes to to the explore section:
It has less ctx menu opts:
If the user tries to navigate to it anyway (though the URL or sth):