This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: remove node buffers #27
Merged
+35
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to the latest interface-datastore that swaps out Buffers for Uint8Arrays. Depends on: - [ ] ipfs/interface-datastore#43 BREAKING CHANGE: no longer uses node Buffers, only Uint8Arrays
achingbrain
added a commit
to ipfs/js-datastore-fs
that referenced
this pull request
Jul 28, 2020
Updates to the latest changes from interface-datastore and datastore-core Depends on: - [ ] ipfs/interface-datastore#43 - [ ] ipfs/js-datastore-core#27 BREAKING CHANGES: only uses Uint8Arrays internally
2 tasks
achingbrain
added a commit
to ipfs/js-datastore-level
that referenced
this pull request
Jul 28, 2020
This module didn't have a lot of buffer use in the first place, but we remove any references to buffers in favour of Uint8Arrays. When quering, values come back as Buffers which are Uint8Arrays so the conversion was unecessary. Depends on: - [ ] ipfs/interface-datastore#43 - [ ] ipfs/js-datastore-core#27 BREAKING CHANGE: remove node buffers in favour of Uint8Arrays
2 tasks
achingbrain
added a commit
to ipfs/js-datastore-pubsub
that referenced
this pull request
Jul 28, 2020
Pulls in the latest interface-datastore and replaces use of node Buffers with Uint8Arrays Depends on: - [ ] ipfs/interface-datastore#43 - [ ] ipfs/js-datastore-core#27 - [ ] libp2p/js-libp2p-record#23
3 tasks
vasco-santos
approved these changes
Jul 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the latest interface-datastore that swaps out Buffers for
Uint8Arrays.
Depends on:
BREAKING CHANGE: no longer uses node Buffers, only Uint8Arrays