Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

tests: add stats and update interface-ipfs-core #1189

Merged
merged 2 commits into from
Jan 26, 2018
Merged

tests: add stats and update interface-ipfs-core #1189

merged 2 commits into from
Jan 26, 2018

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jan 25, 2018

No description provided.

@hacdias hacdias requested a review from daviddias January 25, 2018 18:38
@ghost ghost assigned hacdias Jan 25, 2018
@ghost ghost added the status/in-progress In progress label Jan 25, 2018
@hacdias
Copy link
Member Author

hacdias commented Jan 25, 2018

@diasdavid the tests are failing here:

1) .stats
       .bitswap:
     TypeError: Cannot read property 'bitswap' of undefined
      at Context.it (node_modules\interface-ipfs-core\src\stats.js:35:18)

  2) .stats
       .bitswap Promise:
     TypeError: Cannot read property 'bitswap' of undefined
      at Context.it (node_modules\interface-ipfs-core\src\stats.js:52:25)

  3) .stats
       .bw:
     TypeError: Cannot read property 'bw' of undefined
      at Context.it (node_modules\interface-ipfs-core\src\stats.js:67:18)

  4) .stats
       .bw Promise:
     TypeError: Cannot read property 'bw' of undefined
      at Context.it (node_modules\interface-ipfs-core\src\stats.js:79:25)

  5) .stats
       .repo:
     TypeError: Cannot read property 'repo' of undefined
      at Context.it (node_modules\interface-ipfs-core\src\stats.js:89:18)

  6) .stats
       .repo Promise:
     TypeError: Cannot read property 'repo' of undefined
      at Context.it (node_modules\interface-ipfs-core\src\stats.js:102:25)

Is there any step on the tests I should've done? They seem to work with the API.

@hacdias
Copy link
Member Author

hacdias commented Jan 25, 2018

@diasdavid just noticed JS-IPFS doesnt have .stats implemented.

@hacdias
Copy link
Member Author

hacdias commented Jan 25, 2018

I'll add the bypass to the tests on interface-ipfs-core.

@hacdias
Copy link
Member Author

hacdias commented Jan 25, 2018

@daviddias
Copy link
Member

@hacdias wanna try to take a stab at implementing them?

@hacdias
Copy link
Member Author

hacdias commented Jan 25, 2018

@diasdavid I'll open an issue and assign it to myself. In the meanwhile, I suggest to merge this 😄

@daviddias
Copy link
Member

@hacdias 👍 just waiting on the CI

@hacdias
Copy link
Member Author

hacdias commented Jan 26, 2018

@diasdavid Travis seems to pass 😄

@daviddias daviddias merged commit cfa38ca into master Jan 26, 2018
@daviddias daviddias deleted the stats branch January 26, 2018 09:04
JonKrone pushed a commit that referenced this pull request Feb 16, 2018
* tests: add stats and update interface-ipfs-core

* chore: update interface-ipfs-core
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants