This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
tests: add stats and update interface-ipfs-core #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@diasdavid the tests are failing here:
Is there any step on the tests I should've done? They seem to work with the API. |
@diasdavid just noticed JS-IPFS doesnt have .stats implemented. |
I'll add the bypass to the tests on interface-ipfs-core. |
@hacdias wanna try to take a stab at implementing them? |
@diasdavid I'll open an issue and assign it to myself. In the meanwhile, I suggest to merge this 😄 |
@hacdias 👍 just waiting on the CI |
daviddias
approved these changes
Jan 25, 2018
@diasdavid Travis seems to pass 😄 |
JonKrone
pushed a commit
that referenced
this pull request
Feb 16, 2018
* tests: add stats and update interface-ipfs-core * chore: update interface-ipfs-core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.